Repository navigation
FIX-2242: the FIX-2070 closure walk, workers talk together - #4129
Conversation
…bulary sweep (D2) message-names and message-reply-to join RETIRED, so CI fails a later PR that brings back messageWorker, the relay or an old refusal. --control plants one hit per row. workers-message-each-other's sweep reads the rows instead of its own copy. The Shift Manager fixture rendering takes_tasks_only now renders task_sessions_only, a refusal that exists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
Scenes ac, ed and b walk the epic's legs together on one durable host, plus the D2 sweep and the j1 browser journey, with six controls and a before-state. workers-message-each-other exports the helpers it reuses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
…y what only it was told Helper A gets a standing rule to answer a task's question with updateTask; the ring passes text on word for word; the wait-again line gives the exact input; the question is caught while it is open, since the task read lists open holds only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
…ge can wait Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
…ad from its message and steer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
…stion counts without a matching steer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
|
@codex review I'm least sure about two things in Generated by Claude Code |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture pass (read-only; for the follow-up agent)Overall: the approach earns its scope. Reusing the children's legs, controls and fault patches instead of re-implementing them is right, and folding the 1. The sweep walker now exists twice (do in this PR)
2.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e75e349484
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…wn, the ring overlaps an observed park, b's second answer is new Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
…nused import Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66bd6ce762
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…wn rows, b's first message must overlap the task's turn, kept-once compares the call's hop before and after Scene b's task now writes a long essay so the herald's message reaches it while it runs, and only the task's own turns (not other queued messages) bound when it ended. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b468a04d6b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
Also ports main's one-line fix for the human_input reason left in the task-board settle test, which reds the vocabulary sweep on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
|
Process guards failed in the vocabulary sweep's Generated by Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e493cb86f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… plants Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiDWiB5JZRCvyAFUpe9
…-n6abql # Conflicts: # goals/shift-manager/workers-message-each-other/legs.mts # goals/vocabulary/one-word-per-thing/rules.mjs
The problem
FIX-2070 gave workers a way to talk to each other: they send messages, call each other and wait for the answer, deliver once across a crash, tell a filer its task's question midway, and stop a ring at its budget. Each child proved its own leg on a calm host. Nobody had checked that the legs still work when they happen at once, on one durable host, with a crash in the middle. The closure (FIX-2242) is that check.
What this does
goals/shift-manager/workers-talk-together/, that runs on a real model against Shift Manager's DevTeam over SQLite. Scene ac is a call across a crash. Scene ed is a parked call while a task asks its filer a question and a ring runs. Scene b covers messages to a task. The run also does the removed-names sweep and a browser journey. It has six controls, each of which must fail on its own assertion, and a before-state one2c190e64.message-names,message-reply-to) are now rows in the vocabulary sweep that CI runs.Verdict: FAIL, on two open findings. Everything else passes:
a:answer-in-request(FIX-2269) ande:steer-releases(FIX-2279)e2c190e64workers-message-each-otherevery-stop-is-one-inbox-itemWhat's asked of you
Parts worth reviewing closely
scenes.mts→sceneED: the timing grades (e:heard-while-callingreads the received item's stamp against the request's resume and the call'sdeadlineAt). It also reads the question from the receivedq:<task>:<hold>id when the question is asked and answered between two polls, because the task list shows only open holds.controls.mts→call-holds-session, the one new control.goals/vocabulary/one-word-per-thing/rules.mjs: the two new RETIRED rows and their scopes.Links: spec
specs/issues/FIX-2242/(#4024) · epic FIX-2070 · Linear FIX-2242 · merges as a goal; the closure verdict waits on the blockers above.How to review this
This is a goal, an on-demand acceptance check on a real model. It is not a CI gate. Read
goal.mdfirst. It is the contract: input, signal, anti-game rules and controls. Then check that each assertion inscenes.mtsgrades whatgoal.mdsays it does.Engineering calls
j1:statesgrades the ring's six delivered messages, not a seventhrefusedrow. A budget refusal writes no row (FIX-2238), andgoal.mdrecords the difference from the spec.faultPatches(faults, sender)lets leg c's crash fire only on Helper A's messages.workers-message-each-othernow exports the helpers this goal reuses, andcheckoutFormoved to its own file.rules_addfirst.workers-message-each-othernow asks for a send rather than a call, sincesendMessagecan wait.questions: [](merged).onMessageReceived(moved under the epic)."". Not a blocker, since no shipped flow has no turn.Everything else
unset FSDEV_DEFAULT_MODEL; PLAYWRIGHT_BROWSERS_PATH=<chromium> pnpm tsx goals/shift-manager/workers-talk-together/run.mts. UseGOAL_SCENES,GOAL_CONTROL,GOAL_COMMITandGOAL_KEEP_STOREasgoal.mddescribes.goalstypecheck is clean for these files. The vocabulary sweep reports 0 hits on HEAD and 77 one2c190e, and--controlcatches each plant with its own rule.Generated by Claude Code